Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable eth_sign method #285

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

q20274982
Copy link
Member

Summary

  • show corresponding error when send eth_sign request
  • remove eth_sign relate logic

Related Links

Asana: https://app.asana.com/0/1201812548509877/1205565756840685/f

Checklist

  • Pasted Asana link.
  • Tagged labels.

Prerequisite/Related Pull Requests

@q20274982 q20274982 requested a review from akira02 October 13, 2023 07:38
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: c3cb257

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@blocto/sdk Minor
@blocto/aptos-wallet-adapter-plugin Patch
@blocto/wagmi-connector Patch
@blocto/web3-react-connector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mordochi
mordochi previously approved these changes Oct 16, 2023
packages/blocto-sdk/src/providers/ethereum.ts Outdated Show resolved Hide resolved
@q20274982 q20274982 force-pushed the feat/disable-eth_sign-method branch from 2e2ccd7 to c3cb257 Compare October 26, 2023 05:46
@q20274982 q20274982 merged commit 063451c into develop Oct 26, 2023
1 check passed
@q20274982 q20274982 deleted the feat/disable-eth_sign-method branch October 26, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants